On Mon, 17 Nov 2014 17:48:37 -0800 Joe Perches <j...@perches.com> wrote:
> On Mon, 2014-11-17 at 20:24 -0500, Steven Rostedt wrote: > > On Mon, 17 Nov 2014 17:07:58 -0800 > > Joe Perches <j...@perches.com> wrote: > > > > Look at the next patch. > > > I don't have it and you are not cc'ing me. > > It's on LKML. > > And? There's no convenient way to retrieve it. You're not subscribed? > > Um, that may be the case for seq_file, but it is not the case for > > trace_seq. seq_buf is influenced by seq_file because I have a patch to > > make seq_file use it, but it's also the guts of trace_seq that has some > > different requirements. And it's also not the case with the users of > > seq_buf in the last patch. > > I think your patch subject description needs expanding. > It says seq_buf, nothing about trace. It doesn't need to. This helps out the code. seq_buf has nothing to do with seq_file (yet). > > Perhaps making trace use seq internals is not the right > thing to do. But this code comes from the trace_seq internals. It's a way to combine the code between seq_file and trace_seq. It is influenced by seq_file, but the code is trace_seq. Actually, this patch set has nothing to do with seq_file and finishes up solving a problem with printks dump stacks from NMIs. Look at the path of the seq_buf.c code. > > I also think you should break up this perhaps overlarge > patch set into multiple independent sets that can be applied > in separate chucks rather than all at once. > Why? I'm the one that is maintaining it. It's going to go through my tree and it has almost all the acks I need. I will say the first 13 patches have already been acked and reviewed, and are going to be going into my for-next queue soon. I'll be posting a smaller set with the patches that changed. Well, all but the last 3 patches. Those are the ones that I'm going to work with Linus and Andrew on before I pull them into my tree. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
