On 11/18/2014 02:47 PM, Sudip Mukherjee wrote: > err was of the type u32. it was being compared with < 0, and being > an unsigned variable the comparison would have been always false. > > moreover, err was getting the return value from set_reset_mode() > and xcan_set_bittiming(), and both are returning int. > > Signed-off-by: Sudip Mukherjee <[email protected]> > --- > drivers/net/can/xilinx_can.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c > index 72fe96f..67c2dd4 100644 > --- a/drivers/net/can/xilinx_can.c > +++ b/drivers/net/can/xilinx_can.c > @@ -300,7 +300,8 @@ static int xcan_set_bittiming(struct net_device *ndev) > static int xcan_chip_start(struct net_device *ndev) > { > struct xcan_priv *priv = netdev_priv(ndev); > - u32 err, reg_msr, reg_sr_mask; > + u32 reg_msr, reg_sr_mask; > + int err; > unsigned long timeout; > > /* Check if it is in reset mode */ >
Reviewed-by: Michal Simek <[email protected]> Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
