On Mon, Nov 17, 2014 at 06:40:18PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <[email protected]> > Date: Mon, 17 Nov 2014 18:33:33 +0100 > > The free_percpu() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software.
Thanks for the cleanup! Acked-by: Seth Jennings <[email protected]> > > Signed-off-by: Markus Elfring <[email protected]> > --- > mm/zswap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index ea064c1..35629f0 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -152,8 +152,7 @@ static int __init zswap_comp_init(void) > static void zswap_comp_exit(void) > { > /* free percpu transforms */ > - if (zswap_comp_pcpu_tfms) > - free_percpu(zswap_comp_pcpu_tfms); > + free_percpu(zswap_comp_pcpu_tfms); > } > > /********************************* > -- > 2.1.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
