From: Arnd Bergmann <[email protected]> Date: Thu, 20 Nov 2014 16:11:14 +0100
> A recent patch tried to work around a valid warning for the use of a > deprecated interface by blindly changing from the old > pcmcia_request_exclusive_irq() interface to pcmcia_request_irq(). > > This driver has an interrupt handler that is not currently aware > of shared interrupts, but can be easily converted to be. > At the moment, the driver reads the interrupt status register > repeatedly until it contains only zeroes in the interesting bits, > and handles each bit individually. > > This patch adds the missing part of returning IRQ_NONE in case none > of the bits are set to start with, so we can move on to the next > interrupt source. > > Signed-off-by: Arnd Bergmann <[email protected]> > Fixes: 5f5316fcd08ef7 ("am2150: Update nmclan_cs.c to use update PCMCIA API") > --- > I had this patch in my queue of things to submit and noticed that > the warning had gone away upstream but my patch was still there. > > For all I can tell, the driver is broken without this, although it > would rarely be a problem. I'm happy for this to go alongside patch #2 via another tree: Acked-by: David S. Miller <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
