From: Markus Elfring <[email protected]> Date: Sat, 22 Nov 2014 11:33:16 +0100
The functions smp_set_ops() and unwind_table_del() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- arch/arm/kernel/module.c | 3 +-- arch/arm/kernel/setup.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/kernel/module.c b/arch/arm/kernel/module.c index 6a4dffe..3dffad1 100644 --- a/arch/arm/kernel/module.c +++ b/arch/arm/kernel/module.c @@ -350,7 +350,6 @@ module_arch_cleanup(struct module *mod) int i; for (i = 0; i < ARM_SEC_MAX; i++) - if (mod->arch.unwind[i]) - unwind_table_del(mod->arch.unwind[i]); + unwind_table_del(mod->arch.unwind[i]); #endif } diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 84db893d..a7018a2 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c @@ -929,7 +929,7 @@ void __init setup_arch(char **cmdline_p) if (!mdesc->smp_init || !mdesc->smp_init()) { if (psci_smp_available()) smp_set_ops(&psci_smp_ops); - else if (mdesc->smp) + else smp_set_ops(mdesc->smp); } smp_init_cpus(); -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
