On Mon, 2014-11-24 at 14:41 +0000, David Howells wrote: > Mimi Zohar <[email protected]> wrote: > > > > > Ok, PCKS#7 supports detached data. I assume this is not needed for > > > > kernel modules. What is the motivation for adding this support to the > > > > kernel? > > > > > > See patch #5. I should probably note that in the commit message. > > > > This patch set does not change the syscall. The signature is still > > appended to the kernel module. > > Ummm, yes, so? > > > In fact, the call from kernel/module_signing.c: mod_verify_pkcs7() calls > > pkcs7_supply_detached_data() with a pointer to the module and the module > > length to set the data field. pkcs7_supply_detached_data() would not be > > defined or exported, unless it was going to be called elsewhere. How else > > are you planning on using pkcs7_supply_detached_data()? > > Is your point that I exported it unnecessarily? That I have now fixed.
No, it was more a comment on the function name pkcs7_supply_detached_data() being a bit weird, as the signature is appended to the data. Mimi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
