On Mon, Nov 24, 2014 at 07:48:31PM +0100, Cornelia Huck wrote: > On Mon, 24 Nov 2014 13:52:32 +0200 > "Michael S. Tsirkin" <[email protected]> wrote: > > > Based on patches by Cornelia Rusty and others, but > > with an API that should allow better static checking of code, > > and slightly more concervative changes in vring,net and blk. > > > > Based on patches by Cornelia and others, but > > with an API that should allow better static checking of code, > > slightly more concervative changes in vring and drivers, > > and compatibility for existing drivers so that > > this series be applied before all drivers are converted. > > > > virtio net,blk and scsi drivers have been converted. > > They now pass sparse without warnings. > > > > net and blk patches have been tested on s390. > > vring_transport_features() seems to knock off the version 1 bit (I > wonder why I did not see that before, maybe VIRTIO_TRANSPORT_F_END had > not been increased before?). If I add VIRTIO_F_VERSION_1 in this > function, virtio-net and virtio-blk seem to work fine with version 1 on > virtio-ccw (tested with my old virtio-1 qemu branch).
What if we just move VIRTIO_TRANSPORT_F_END back for now? Does patch below fix it for you? > I'll try to do a bit of reviewing tomorrow. BTW could you post your latest qemu bits please? diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index a6d0cde..0071de9 100644 --- a/include/uapi/linux/virtio_config.h +++ b/include/uapi/linux/virtio_config.h @@ -47,7 +47,7 @@ * transport being used (eg. virtio_ring), the rest are per-device feature * bits. */ #define VIRTIO_TRANSPORT_F_START 28 -#define VIRTIO_TRANSPORT_F_END 33 +#define VIRTIO_TRANSPORT_F_END 32 /* Do we get callbacks when the ring is completely used, even if we've * suppressed them? */ -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
