On Mon, Apr 11, 2005 at 08:12:34AM +0200, Jens Axboe wrote: > On Sun, Apr 10 2005, Adrian Bunk wrote: > > This patch contains the following possible cleanups: > > - make needlessly global code static > > - remove the following unused global functions: > > - blkdev_scsi_issue_flush_fn > > Kill the function completely, it is not used anymore. > > > - __blk_attempt_remerge > > Normally I would say leave that since it's part of the API, but lets > just kill it. I don't envision any further users of the remerging > attempts. > > > - remove the following unused EXPORT_SYMBOL's: > > - blk_phys_contig_segment > > - blk_hw_contig_segment > > - blkdev_scsi_issue_flush_fn > > - __blk_attempt_remerge > > > > Please review which of these changes make sense. > > Looks fine to me, thanks. Can you send a new patch that kills > blkdev_scsi_issue_flush_fn()?
I have a problem parsing your email. Which parts of my patch are OK and which shouldn't be applied? Or why do you want a separate blkdev_scsi_issue_flush_fn patch? > Jens Axboe cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/