LGTM
On Mon, Nov 24, 2014 at 9:02 PM, Andrey Ryabinin <[email protected]> wrote: > Remove static and add function declarations to mm/slab.h so they > could be used by kernel address sanitizer. > > Signed-off-by: Andrey Ryabinin <[email protected]> > --- > include/linux/slub_def.h | 5 +++++ > mm/slub.c | 4 ++-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h > index c75bc1d..144b5cb 100644 > --- a/include/linux/slub_def.h > +++ b/include/linux/slub_def.h > @@ -115,4 +115,9 @@ static inline void *virt_to_obj(struct kmem_cache *s, > void *slab_page, void *x) > return x - ((x - slab_page) % s->size); > } > > +__printf(3, 4) > +void slab_err(struct kmem_cache *s, struct page *page, const char *fmt, ...); > +void object_err(struct kmem_cache *s, struct page *page, > + u8 *object, char *reason); > + > #endif /* _LINUX_SLUB_DEF_H */ > diff --git a/mm/slub.c b/mm/slub.c > index 95d2142..0c01584 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -629,14 +629,14 @@ static void print_trailer(struct kmem_cache *s, struct > page *page, u8 *p) > dump_stack(); > } > > -static void object_err(struct kmem_cache *s, struct page *page, > +void object_err(struct kmem_cache *s, struct page *page, > u8 *object, char *reason) > { > slab_bug(s, "%s", reason); > print_trailer(s, page, object); > } > > -static void slab_err(struct kmem_cache *s, struct page *page, > +void slab_err(struct kmem_cache *s, struct page *page, > const char *fmt, ...) > { > va_list args; > -- > 2.1.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
