On Mon, 01 Dec 2014, Linus Walleij wrote: > On Fri, Nov 28, 2014 at 5:41 PM, Muthu Mani <m...@cypress.com> wrote: > > > Adds support for USB-GPIO interface of Cypress Semiconductor > > CYUSBS234 USB-Serial Bridge controller. > > > > The GPIO get/set can be done through vendor command on control endpoint > > for the configured gpios. > > > > Details about the device can be found at: > > http://www.cypress.com/?rID=84126 > > > > Signed-off-by: Muthu Mani <m...@cypress.com> > > Signed-off-by: Rajaram Regupathy <r...@cypress.com> > > --- > > Changes since v3: > > (..) > > +config GPIO_CYUSBS23X > > + tristate "CYUSBS23x GPIO support" > > + depends on MFD_CYUSBS23X && USB > > Doesn't MFD_CYUSV23X already depend on USB?
Yup. > > +#include <linux/kernel.h> > > +#include <linux/errno.h> > > +#include <linux/module.h> > > +#include <linux/slab.h> > > +#include <linux/types.h> > > +#include <linux/mutex.h> > > +#include <linux/platform_device.h> > > + > > +#include <linux/usb.h> > > +#include <linux/gpio.h> > > + > > +#include <linux/mfd/cyusbs23x.h> > > Why this arbitrary newlines? Add this > > #include <linus/bitops.h> Narcissist. =;-) [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
