On Tue, Dec 2, 2014 at 9:04 AM, Steven Rostedt <[email protected]> wrote: > \ > - return match; \ > + return match == !pred->not; \
are you sure this one works for !(var & 2) ? 'not' is either 0 or 1, so it works for other macro: (val == *addr) ^ pred->not whereas here 'match' is 'int' and match = (*addr & val) will not be 0 or 1... the patch is small, but delicate... In such cases I trust tests more than code review ;) Could you add few tests for this to CONFIG_FTRACE_STARTUP_TEST part of the file ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
