On 21/11/14 16:42, Vivek Goyal wrote:
> On Thu, Nov 20, 2014 at 04:54:03PM +0000, David Howells wrote:
>
> [..]
>> diff --git a/crypto/asymmetric_keys/x509_parser.h
>> b/crypto/asymmetric_keys/x509_parser.h
>> index 3dfe6b5d6f0b..223b72344060 100644
>> --- a/crypto/asymmetric_keys/x509_parser.h
>> +++ b/crypto/asymmetric_keys/x509_parser.h
>> @@ -21,7 +21,8 @@ struct x509_certificate {
>> char *subject; /* Name of certificate subject
>> */
>> struct asymmetric_key_id *id; /* Serial number + issuer */
>> struct asymmetric_key_id *skid; /* Subject + subjectKeyId
>> (optional) */
>> - struct asymmetric_key_id *authority; /* Authority key identifier
>> (optional) */
>> + struct asymmetric_key_id *auth_id; /* CA AuthKeyId matching ->id
>> (optional) */
>> + struct asymmetric_key_id *auth_skid; /* CA AuthKeyId matching ->skid
>> (optional) */
> A very minor nit. It might help if we put additional comment to explain what
> auth_id and auth_skid are composed of (like other key ids).
>
> auth_id /* akid issuer + akid serial */
> auth_skid /* issuer + akid keyid */
>
> Thanks
> Vivek
>
Right,
David did not address this in his v2 patchset...
- Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
