Am 04.12.2014 um 17:44 schrieb Tanya Brokhman: > On 11/27/2014 5:38 PM, Artem Bityutskiy wrote: >> On Mon, 2014-11-24 at 14:20 +0100, Richard Weinberger wrote: >>> ...otherwise the deferred work might run after datastructures >>> got freed and corrupt memory. >>> >>> Signed-off-by: Richard Weinberger <[email protected]> >>> --- >>> drivers/mtd/ubi/wl.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c >>> index 7f135df..cb2e571 100644 >>> --- a/drivers/mtd/ubi/wl.c >>> +++ b/drivers/mtd/ubi/wl.c >>> @@ -2041,6 +2041,9 @@ static void protection_queue_destroy(struct >>> ubi_device *ubi) >>> void ubi_wl_close(struct ubi_device *ubi) >>> { >>> dbg_wl("close the WL sub-system"); >>> +#ifdef CONFIG_MTD_UBI_FASTMAP >>> + flush_work(&ubi->fm_work); >>> +#endif >> >> If you are using the work infrastructure implemented in wl.c, then >> fastmap work should be no different to any other work. And we do flush >> all works in 'shutdown_work()'. The fastmap work should be flushed there >> too. > > I tend to agree with Artem. Could you please move it to shutdown_work()? I'm > asking because I do want to pick up all the bug fixes patches, but not going > to pick up the "cleaning > up" patches at this point.
Okay. You have overruled me. :-) Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
