Joshua, On Fri, Dec 05, 2014 at 01:47:34PM +0900, Joshua I. James wrote: > From: "Joshua I. James" <[email protected]> > > Fixed style errors identified by checkpatch. > > Output of checkpatch: > WARNING: Missing a blank line after declarations > WARNING: line over 80 characters > ERROR: spaces required around that '==' (ctx:VxV) > +#if ACCT_VERSION==2 >
It looks like your patch is making three types of changes. A single patch should make a single type of change. For example, you might fix all the "blank line after declaration" warnings in one patch. Doing this helps make your patches easier to review, and if a problem arises later, easier to bisect. > Signed-off-by: Joshua I. James <[email protected]> > --- > kernel/acct.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/kernel/acct.c b/kernel/acct.c > index 33738ef..322159c 100644 > --- a/kernel/acct.c [...] It also looks like you only sent this to the linux-kernel mailing list. You should use scripts/get_maintainer.pl to find who to send it to. Hope that helps :-) -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
