On Fri, Dec 05, 2014 at 07:39:12PM +0530, Athira Lekshmi C V wrote: > Hello > > Should I resubmit the above patch again including the version number, > or can I start doing so from the next time onwards ? > Not a big deal this time but definitely do it in the future.
Another tip: try to avoid posting, it can make the conversation confusing [1]. [1]: https://lkml.org/lkml/2005/1/11/111 > Thank You > Athira Lekshmi > > On Fri, Dec 5, 2014 at 7:30 PM, Jeremiah Mahler <[email protected]> wrote: > > Athira, > > > > On Fri, Dec 05, 2014 at 07:13:54PM +0530, Athira Lekshmi wrote: > >> Fixed the checkpatch warning: > >> Missing a blank line after declarations > >> > >> Signed-off-by: Athira Lekshmi <[email protected]> > >> --- > >> drivers/watchdog/mixcomwd.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/watchdog/mixcomwd.c b/drivers/watchdog/mixcomwd.c > >> index be86ea3..03b7612e 100644 > >> --- a/drivers/watchdog/mixcomwd.c > >> +++ b/drivers/watchdog/mixcomwd.c > >> @@ -183,6 +183,7 @@ static ssize_t mixcomwd_write(struct file *file, const > >> char __user *data, > >> > >> for (i = 0; i != len; i++) { > >> char c; > >> + > >> if (get_user(c, data + i)) > >> return -EFAULT; > >> if (c == 'V') > >> -- > >> 1.7.9.5 > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > >> the body of a message to [email protected] > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> Please read the FAQ at http://www.tux.org/lkml/ > > > > It is helpful to add a version number when patches are re-submitted to > > avoid them being confused for a new patch. git-format-patch has the > > --reroll-count option which makes this easy to do. > > > > -- > > - Jeremiah Mahler -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
