On Tuesday 09 December 2014 21:23:04 Guenter Roeck wrote: > On Tue, Dec 09, 2014 at 09:06:59PM +0100, Pali Rohár wrote: > > Driver mix speed and rpm. Fan speed is value (0, 1, 2) which > > is used for configuring fan. This patch change comments, > > function names and other definitions so code should be > > unambiguous now. > > > > Signed-off-by: Pali Rohár <[email protected]> > > --- > > This patch is cosmetic and does not bring any change to > > code. > > For me "speed" and "rpm" are synonyms. So you are not really > clarifying anything. If anything, you make the code even more > confusing. > > Guenter
Ok, what do you want to use instead "speed" and "rpm" to make it clear? We have function which returns RPM and other functions which get/set fan speed value (which is 0, 1 or 2). And new function (from patch 2) returns nominal RPM for fan speed value. -- Pali Rohár [email protected]
signature.asc
Description: This is a digitally signed message part.
