On Wed, Dec 10, 2014 at 05:55:02PM +0800, Yingjoe Chen wrote: > Beniamino reported a kernel oops caused by an invalid DT file for the > mediatek interrupt polarity extension. > > The reason is that the interrupt polarity support for mediatek chips > merely checks for NULL pointer instead of a casted error return > value in mtk_sysirq_of_init() so any other casted error value passes > the NULL pointer check and causes a kernel panic when dereferenced. > > Use IS_ERR() and return the error value via PTR_ERR(). > > Reported-and-tested-by: Beniamino Galvani <[email protected]>
Well, actually I only reported the bug and didn't do any test. Can the "-and-tested" portion of the tag be dropped while applying the patch? Beniamino > Signed-off-by: Yingjoe Chen <[email protected]> > --- > drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c > b/drivers/irqchip/irq-mtk-sysirq.c > index 7e342df..0b0d2c0 100644 > --- a/drivers/irqchip/irq-mtk-sysirq.c > +++ b/drivers/irqchip/irq-mtk-sysirq.c > @@ -137,9 +137,9 @@ static int __init mtk_sysirq_of_init(struct device_node > *node, > return -ENOMEM; > > chip_data->intpol_base = of_io_request_and_map(node, 0, "intpol"); > - if (!chip_data->intpol_base) { > + if (IS_ERR(chip_data->intpol_base)) { > pr_err("mtk_sysirq: unable to map sysirq register\n"); > - ret = -ENOMEM; > + ret = PTR_ERR(chip_data->intpol_base); > goto out_free; > } > > -- > 1.8.1.1.dirty > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
