On Wed, 10 Dec 2014, Pekka Enberg wrote: > > +static bool same_slab_page(struct kmem_cache *s, struct page *page, void > > *p) > > Why are you passing a pointer to struct kmem_cache here? You don't > seem to use it.
True. > > +{ > > + long d = p - page->address; > > + > > + return d > 0 && d < (1 << MAX_ORDER) && d < (compound_order(page) > > << PAGE_SHIFT); > > +} > > Can you elaborate on what this is doing? I don't really understand it. Checks if the pointer points to the slab page. Also it tres to avoid having to call compound_order needlessly. Not sure if that optimization is worth it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/