On Tue, Dec 16, 2014 at 12:07:19AM +0100, Rickard Strandqvist wrote: > Hi Dan > > Quite right! Had to try it. > > Do nothing then? > But you must agree that it is still ugly and confusing code. >
Yes. I agree that it's confusing. I also suspect that "obd" is never NULL but I haven't actually looked and these things are sometimes complicated to verify. I fine with merging the patch as a cleanup. Smatch has code to not warn about these but it's not 100% correct so it still warns sometimes when it shouldn't. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
