On Sunday, December 14, 2014 09:06:38 AM Prarit Bhargava wrote: > sysfs_get_idlestate_count() returns an unsigned int. Returning -ENODEV > is not the right thing to do here, and in any case is handled the same > way as if there are no states found. Yep, returning zero states instead of an error code makes a lot sense here.
> > Cc: Thomas Renninger <[email protected]> > Cc: Rafael J. Wysocki <[email protected]> > Signed-off-by: Prarit Bhargava <[email protected]> Acked-by: Thomas Renninger <[email protected]> Thanks! Thomas > --- > tools/power/cpupower/utils/helpers/sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/power/cpupower/utils/helpers/sysfs.c > b/tools/power/cpupower/utils/helpers/sysfs.c index 09afe5d..4e8fe2c 100644 > --- a/tools/power/cpupower/utils/helpers/sysfs.c > +++ b/tools/power/cpupower/utils/helpers/sysfs.c > @@ -361,7 +361,7 @@ unsigned int sysfs_get_idlestate_count(unsigned int cpu) > > snprintf(file, SYSFS_PATH_MAX, PATH_TO_CPU "cpuidle"); > if (stat(file, &statbuf) != 0 || !S_ISDIR(statbuf.st_mode)) > - return -ENODEV; > + return 0; > > snprintf(file, SYSFS_PATH_MAX, PATH_TO_CPU "cpu%u/cpuidle/state0", cpu); > if (stat(file, &statbuf) != 0 || !S_ISDIR(statbuf.st_mode)) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
