On Thu, 18 Dec 2014 10:19:06 +1100, NeilBrown said: > On Wed, 17 Dec 2014 10:49:33 -0500 Nicholas Krause <[email protected]> > wrote: > > > Removes the no longer needed fix me comment related to not needing the > > agrument faster for the function, > > sync_request. Due to getting warnings when building without the agrument it > > seems that this fix me was > > wrong and we must keep this agrument in order to avoid build warnings when > > building without it.
Examining raid1.c, which *does* use the go_faster parameter, I suspect
that the *real* meaning of the FIXME is that the code in raid5.c *should*
possibly be doing this that's done in raid1.c's sync_request():
/*
* If there is non-resync activity waiting for a turn,
* and resync is going fast enough,
* then let it though before starting on this new sync request.
*/
if (!go_faster && conf->nr_waiting)
msleep_interruptible(1000);
(Which is one of the few flow differences for the sync_request() code
in raid1.c versus raid5.c. I'll however defer to actual RAID experts
on whether raid5 needs resync throttling, or if it's accomplished via
other means I'm not spotting. Finding a FIXME outside of drivers/staging
is usually a "Here be fearsome and nasty dragons" comment....
pgpqU6bimluSx.pgp
Description: PGP signature
