On 2014-12-28 14:20, Christoffer Dall wrote:
Commit 0b46b8a718c6e ("clocksource: arch_timer: Fix code to...")
fixes
timer issues with certain ARMv7 platforms, but unfortunately breaks
arm64 platforms with hyp mode (EL2) enabled.
The commit only sets arch_timer_use_virtual to false under
CONFIG_ARM,
but forgets that the config variable is also set in other code paths
(actually, right underneath the check in the patch) with detrimental
consequences as we've now introduced a direct early call to BUG() on
practically all arm64 platforms.
One could argue that this code could be refactored to use different
variables for checking which *timer* to use and which *counter* to
use,
which seems to be the desired difference between ARM and arm64 in
this
case, but this approach fixes an urgent issue for now.
Cc: Sonny Rao <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Olof Johansson <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Marc Zyngier <[email protected]>
Cc: Yingjoe Chen <[email protected]>
Signed-off-by: Christoffer Dall <[email protected]>
---
This was apparently already discovered by Yingjoe Chen in this thread
https://lkml.org/lkml/2014/11/24/41 and Catalin recommended a similar
fix.
I'm increasingly worried about the time it takes to get such critical
fixes into the tree (arm64 is *dead* without it).
What is holding this patch which, as far as I remember, has been posted
by Catalin almost three weeks ago?
Daniel?
M.
--
Fast, cheap, reliable. Pick two.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
