Reviewed-by: Andreas Platschek <[email protected]> Signed-off-by: Nicholas Mc Guire <[email protected]> --- scripts/coccinelle/api/false_init_compltion.cocci | 74 +++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 scripts/coccinelle/api/false_init_compltion.cocci
diff --git a/scripts/coccinelle/api/false_init_compltion.cocci b/scripts/coccinelle/api/false_init_compltion.cocci new file mode 100644 index 0000000..a97dfcf --- /dev/null +++ b/scripts/coccinelle/api/false_init_compltion.cocci @@ -0,0 +1,74 @@ +/* check for incorrect use of multiple init_completion on the + * same struct completion and switch the reinitializations to use + * reinit_completion() + * + * Options: --no-includes --include-headers + */ +virtual context +virtual patch +virtual org +virtual report + +/* mark first call to init_completion */ +@c@ +expression cmp; +position p; +@@ + + init_completion@p(cmp) + +/* flag incorrect reinitializations */ +@d depends on patch && !(context || org || report)@ +expression E,c.cmp; +identifier f; +position c.p,p1; +@@ + + init_completion@p(cmp) + <+... +( + E = cmp +| + E = &cmp +| + f(..., cmp,...) +| + f(..., &cmp,...) +) + ...+> +- init_completion@p1(cmp) ++ reinit_completion1(cmp) + +@dp depends on !patch && (context || org || report)@ +identifier f; +expression E,c.cmp; +position c.p,p1; +@@ + + init_completion@p(cmp) + <+... +( + E = cmp +| + E = &cmp +| + f(..., cmp,...) +| + f(..., &cmp,...) +) + ...+> + init_completion@p1(cmp) + +@script:python depends on org@ +p << dp.p1; +@@ + +msg="WARNING: possible reinit by init_completion" +coccilib.org.print_todo(p[0], msg) + +@script:python depends on report@ +p << dp.p1; +@@ + +msg="WARNING: possible reinit by init_completion" +coccilib.report.print_report(p[0], msg) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
