> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, January 09, 2015 12:09 PM > To: david.lai...@aculab.com > Cc: Hau; net...@vger.kernel.org; nic_swsd; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next 07/11] r8169:update rtl8168f pcie ephy > parameter > > From: David Laight <david.lai...@aculab.com> > Date: Wed, 7 Jan 2015 16:45:58 +0000 > > > From: Chunhao Lin > >> @@ -5852,7 +5852,9 @@ static void rtl_hw_start_8168f_1(struct > rtl8169_private *tp) > >> { 0x06, 0x00c0, 0x0020 }, > >> { 0x08, 0x0001, 0x0002 }, > >> { 0x09, 0x0000, 0x0080 }, > >> - { 0x19, 0x0000, 0x0224 } > >> + { 0x19, 0x0000, 0x0224 }, > >> + { 0x00, 0x0000, 0x0008 }, > >> + { 0x0c, 0x3df0, 0x0200 } > > > > I can't help feeling these lines all require short comments. > > Agreed. > > And this goes for some of the other patches that look like this too. > I will merge the patches and update again.
Thanks. ------Please consider the environment before printing this e-mail. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
