On 16/01/2015 04:02, Michael Ellerman wrote: > On Thu, 2015-01-15 at 15:41 -0800, Tyrel Datwyler wrote: >> On 01/15/2015 02:19 PM, Michael Ellerman wrote: >> If this was on a powerkvm guest set-indicator should be present for >> hotplug (DLPAR) support. However, the surveillance indicator would not >> be implemented. I know sometimes I forget if I'm on a powervm or >> powerkvm guest. Just a thought. > > Right that does explain it. I went looking for the KVM kernel/qemu code that > implements set-indicator but couldn't find it. Presumably it's in some branch > other than the one I was looking at, or I was grepping for the wrong thing. > > So I guess a printf there is probably not helpful, because it will fire always > on PowerKVM (at least at the moment).
FWIW, the PAPR mentions that the surveillance indicator may not be implemented. In that case -3 is returned.? I double checked that on my LPAR. One option would be to warn only if the returned value is different from 0 and -3. Cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
