Am 17.01.2015 um 19:23 schrieb Nicholas Krause: > This removes the no longer needed TODO comment for questioning if > the function,gigaset_procinfo needs to do more work internally. This > comment is no longer needed due to the function's intended use to be > returning the name of the structure pointer passed to this function > of type,capi_ctr. In addition due to this the function's comments > related to it's intended job are changed to state it returns rather > then builds the description for the structure and also that the > function doesn't build the name string but returns the already > generated one passed to gigaset_procinfo by the structure passed > to this function. > > Signed-off-by: Nicholas Krause <[email protected]>
Acked-by: Tilman Schmidt <[email protected]> Thanks, Tilman > --- > drivers/isdn/gigaset/capi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c > index ccec777..c4d666e 100644 > --- a/drivers/isdn/gigaset/capi.c > +++ b/drivers/isdn/gigaset/capi.c > @@ -2336,14 +2336,14 @@ static u16 gigaset_send_message(struct capi_ctr *ctr, > struct sk_buff *skb) > } > > /** > - * gigaset_procinfo() - build single line description for controller > + * gigaset_procinfo() - return single line description for controller > * @ctr: controller descriptor structure. > * > - * Return value: pointer to generated string (null terminated) > + * Return value: pointer to already generated string (null terminated) > */ > static char *gigaset_procinfo(struct capi_ctr *ctr) > { > - return ctr->name; /* ToDo: more? */ > + return ctr->name; > } > > static int gigaset_proc_show(struct seq_file *m, void *v) > -- Tilman Schmidt E-Mail: [email protected] Bonn, Germany Diese Nachricht besteht zu 100% aus wiederverwerteten Bits. Ungeöffnet mindestens haltbar bis: (siehe Rückseite) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
