Commit-ID: 1b43d7125f3b6f7d46e72da64f65f3187a83b66b Gitweb: http://git.kernel.org/tip/1b43d7125f3b6f7d46e72da64f65f3187a83b66b Author: Andy Shevchenko <[email protected]> AuthorDate: Wed, 14 Jan 2015 18:39:31 +0200 Committer: Thomas Gleixner <[email protected]> CommitDate: Tue, 20 Jan 2015 12:50:14 +0100
x86: pmc-atom: Assign debugfs node as soon as possible pmc_dbgfs_unregister() will be called when pmc->dbgfs_dir is unconditionally NULL on error path in pmc_dbgfs_register(). To prevent this we move the assignment to where is should be. Fixes: f855911c1f48 (x86/pmc_atom: Expose PMC device state and platform sleep state) Reported-by: Thomas Gleixner <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Cc: Aubrey Li <[email protected]> Cc: Rafael J. Wysocki <[email protected]> Cc: Kumar P. Mahesh <[email protected]> Link: http://lkml.kernel.org/r/1421253575-22509-2-git-send-email-andriy.shevche...@linux.intel.com Signed-off-by: Thomas Gleixner <[email protected]> --- arch/x86/kernel/pmc_atom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/pmc_atom.c b/arch/x86/kernel/pmc_atom.c index 0ee5025e..8bb9a61 100644 --- a/arch/x86/kernel/pmc_atom.c +++ b/arch/x86/kernel/pmc_atom.c @@ -217,6 +217,8 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc, struct pci_dev *pdev) if (!dir) return -ENOMEM; + pmc->dbgfs_dir = dir; + f = debugfs_create_file("dev_state", S_IFREG | S_IRUGO, dir, pmc, &pmc_dev_state_ops); if (!f) { @@ -229,7 +231,7 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc, struct pci_dev *pdev) dev_err(&pdev->dev, "sleep_state register failed\n"); goto err; } - pmc->dbgfs_dir = dir; + return 0; err: pmc_dbgfs_unregister(pmc); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
