On 28/01/15 22:33, Rickard Strandqvist wrote:
Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist <rickard_strandqv...@spectrumdigital.se>
---
  drivers/staging/comedi/drivers/addi_apci_3501.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/comedi/drivers/addi_apci_3501.c 
b/drivers/staging/comedi/drivers/addi_apci_3501.c
index a726efc..0cdcecc 100644
--- a/drivers/staging/comedi/drivers/addi_apci_3501.c
+++ b/drivers/staging/comedi/drivers/addi_apci_3501.c
@@ -267,7 +267,6 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
        struct apci3501_private *devpriv = dev->private;
        unsigned int ui_Timer_AOWatchdog;
        unsigned long ul_Command1;
-       int i_temp;

        /*  Disable Interrupt */
        ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
        ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
        ul_Command1 = ((ul_Command1 & 0xFFFFF9FDul) | 1 << 1);
        outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
-       i_temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
+       inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;

Same as for hwdrv_apci3501.c, the ' & 0x1' part should be removed to avoid compiler warnings.

Keep the inl() call as it might have side-effects for the watchdog functionality of the board.


        return IRQ_HANDLED;
  }



--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbo...@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to