While it may not be productive to perturb seemingly working code (as Rafael argues), it may also not be productive to have decreased code readability (as Quentin suggests).
Personally I prefer readability enhancements over worrying about possibly breaking working code. I don't want to start a flame war so I won't go into arguing this as a better position. I'd just like to thank Quentin for his efforts to identify boolean uses of variables. It's something I'm interested in as well and have been working on in a branch of my own git repository. Quentin if you want to work on this together at all, that'd be great. Please contact me directly as I'm not subscribed to the LKML. As for the original semantic patch code, it's unlikely that it would be safe to not exclude variables that are passed by address (and seemingly the ampersand operator applied on x - as in '&x' - should be a part of the exclusion set). Lou -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
