On Sunday 01 February 2015 06:32 PM, Nicholas Mc Guire wrote:
return type of wait_for_completion_timeout is unsigned long not int, this
patch adds an appropriate variable and fixes up the assignment.
As the string in dev_err already states "timeout" there is little point in
printing the 0 here as it just restates "timeout".
Looks good to me. Thanks for fixing this.
I think it is good if we fix the typo here also.

Acked-by: Laxman Dewangan <ldewan...@nvidia.com>

-       if (WARN_ON(ret == 0)) {
-               dev_err(tspi->dev,
-                       "spi trasfer timeout, err %d\n", ret);
+       if (WARN_ON(dma_timeout == 0)) {
+               dev_err(tspi->dev, "spi trasfer timeout\n");
trasfer->transfer

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to