On Mon, 2 Feb 2015 09:59:16 -0500 Christoph Jaeger <[email protected]> wrote:
> Keyword 'boolean' for type definition attributes is considered > deprecated and, therefore, should not be used anymore. > > See http://lkml.kernel.org/r/[email protected] > See http://lkml.kernel.org/r/[email protected] > > ... > > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -14,7 +14,7 @@ config BITREVERSE > tristate > > config HAVE_ARCH_BITREVERSE > - boolean > + bool > default n > depends on BITREVERSE > help Your patch patches 556d2f055bf6d ("ARM: 8187/1: add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction") which appears in linux-next via the ARM tree. There are many uses of "boolean" in lib/Kconfig. Converting just one of them is inefficient and odd. 556d2f055bf6d is a bit of a surprise. It looks good to me from a non-ARM perspective - the __builtin_constant_p() optimisation is sensible, although bitrev on a constant probably isn't very common. I'm not sure about the ARM part though! __bitrev8() is pretty damn fast. Presumably an inlined rbit instruction is faster still, but not very much? The Kconfig help text in 556d2f055bf6d rather needs some caring for. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
