On Mon, Feb 09, 2015 at 11:27:21AM +0000, Russell King - ARM Linux wrote: > On Mon, Feb 09, 2015 at 12:25:00PM +0100, Sascha Hauer wrote: > > On Mon, Feb 09, 2015 at 10:51:34AM +0000, Russell King - ARM Linux wrote: > > > On Mon, Feb 09, 2015 at 11:47:21AM +0100, Sascha Hauer wrote: > > > > From: James Liao <[email protected]> > > > > > > > > This patch adds MT8135 clock controllers into device tree. > > > > @@ -86,6 +87,18 @@ > > > > clock-frequency = <32000>; > > > > #clock-cells = <0>; > > > > }; > > > > + > > > > + clk_null: clk_null { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <0>; > > > > + }; > > > > + > > > > + clk26m: clk26m { > > > > + compatible = "fixed-clock"; > > > > + #clock-cells = <0>; > > > > + clock-frequency = <26000000>; > > > > + }; > > > > > > Is this supposed to be here? > > > > The clock support needs at least the clk26m clk. Do you think it should > > be in another patch or not present at all? > > I didn't see anything which referenced either clk_null or clk26m in this > patch. My main concern was that clk_null, but my concern grew when I > found that clk26m wasn't referenced either. > > If the MT8135 needs it, shouldn't something in its description reference > this clock?
It's used in the code. The mt8135 clk code directly uses the names of these three clocks as parent_names. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
