On Wed, Feb 11, 2015 at 08:27:17AM -0700, David Ahern wrote: > On 2/10/15 4:42 PM, Stephane Eranian wrote: > >diff --git a/tools/perf/Documentation/perf-inject.txt > >b/tools/perf/Documentation/perf-inject.txt > >index dc7442c..237f195 100644 > >--- a/tools/perf/Documentation/perf-inject.txt > >+++ b/tools/perf/Documentation/perf-inject.txt > >@@ -40,6 +40,17 @@ OPTIONS > > Merge sched_stat and sched_switch for getting events where and how long > > tasks slept. sched_switch contains a callchain where a task slept and > > sched_stat contains a timeslice how long a task slept. > >+-j:: > >+--jit:: > >+ Merge a jitdump file into the perf.data file by adding mmap records to > >+ cover jitted code and emit ELF images for each jitted function. The ELF > >+ images are saved in the same directory as the jidump. Use -E to suppress > >+ ELF images generation. > >+-E:: > >+--jit-disable-elf:: > >+ When used with -, it prevents creating the ELF images for each jitted > >+ function. Only the jitted code mmap records are injected into the > >perf.data > >+ file. Option as no effect when -j is not used. > > s/as/has/. But it would better to avoid the double negative. Maye something > like this instead: > > This option requires -j|--jit.
I think same thing may go to the option name itself. It can be, say, --jit-create-elf and turned on by default. When one wants to disable it, [s]he can use --no-jit-create-elf. Of course this way we cannot use the short name (-E) for disabling tho. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
