On Thu, 22 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching <micky_ch...@realsil.com.cn>
>
> add support for new chip rts525A.
>
> Signed-off-by: Micky Ching <micky_ch...@realsil.com.cn>
> ---
> drivers/mfd/rts5249.c | 104
> ++++++++++++++++++++++++++++++++++++++++++-
> drivers/mfd/rtsx_pcr.c | 13 ++++--
> drivers/mfd/rtsx_pcr.h | 1 +
> include/linux/mfd/rtsx_pci.h | 15 +++++++
> 4 files changed, 129 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
> index 97dde92..134e03f 100644
> --- a/drivers/mfd/rts5249.c
> +++ b/drivers/mfd/rts5249.c
> @@ -97,7 +97,7 @@ static void rtsx_base_force_power_down(struct rtsx_pcr
> *pcr, u8 pm_state)
> rtsx_pci_write_register(pcr, AUTOLOAD_CFG_BASE + 3, 0x01, 0);
>
> if (pm_state == HOST_ENTER_S3) {
> - if (PCI_PID(pcr) == 0x524A)
> + if (PCI_PID(pcr) == 0x524A || PCI_PID(pcr) == 0x525A)
Please consider holding a pm_ctrl_reg attribute in the device data
structure, then only doing this once during initialisation.
Other than that, I have the same comments as before.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
