Hi,
On 25/02/2015 at 23:17:48 +0100, Sebastian Reichel wrote :
> > @@ -350,6 +378,9 @@ static int bq27x00_battery_read_cyct(struct
> > bq27x00_device_info *di)
> > {
> > int cyct;
> >
> > +
>
> spurious newline.
>
> > + if (di->chip == BQ27510)
> > + cyct = bq27x00_read(di, BQ27510_REG_CYCT, false);
> > cyct = bq27x00_read(di, BQ27x00_REG_CYCT, false);
>
> missing else?
>
Indeed, I just sent v2. However, I'm not too happy with all that if/else
layering in this driver. I'll try to rework it so that it scales better.
Regards,
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
