>> +#define UFSHCD_UPDATE_TAG_STATS(hba, tag) >> +#define UFSHCD_UPDATE_TAG_STATS_COMPLETION(hba, cmd) >> +#define UFSHCD_UPDATE_ERROR_STATS(hba, type) >> + >> +#endif > > Is there any reason that these are defined as macros instead of > static functions?
No special reason that I'm aware of. I will convert those to functions. >> out_remove_scsi_host: >> @@ -5769,6 +5969,7 @@ exit_gating: >> out_disable: >> hba->is_irq_enabled = false; >> scsi_host_put(host); >> + ufsdbg_remove_debugfs(hba); >> ufshcd_hba_exit(hba); >> out_error: >> return err; > > This ufsdbg_remove_debugfs() call on error path of ufshcd_init() is > unnecessary. Because ufsdbg_add_debugfs() is called at the last of > ufshcd_init() and can't fail. > I will fix this in the next patchset. -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
