The newly added cros_ec_lpc driver is meant for x86 but can also be built on other architectures. However, the original version causes a compile error when built on ARM because of a missing #include:
drivers/platform/chrome/cros_ec_lpc.c: In function 'ec_response_timed_out': drivers/platform/chrome/cros_ec_lpc.c:40:3: error: implicit declaration of function 'inb' [-Werror=implicit-function-declaration] if (!(inb(EC_LPC_ADDR_HOST_CMD) & EC_LPC_STATUS_BUSY_MASK)) ^ This includes linux/io.h to make it compile reliably. Signed-off-by: Arnd Bergmann <[email protected]> Fixes: ec2f33ab582bf ("platform/chrome: Add cros_ec_lpc driver for x86 devices") Cc: Bill Richardson <[email protected]> Cc: Javier Martinez Canillas <[email protected]> Cc: Gwendal Grignou <[email protected]> Cc: Olof Johansson <[email protected]> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c index 822fdb36ded9..f00bf4d246a1 100644 --- a/drivers/platform/chrome/cros_ec_lpc.c +++ b/drivers/platform/chrome/cros_ec_lpc.c @@ -23,6 +23,7 @@ #include <linux/dmi.h> #include <linux/delay.h> +#include <linux/io.h> #include <linux/mfd/cros_ec.h> #include <linux/mfd/cros_ec_commands.h> #include <linux/module.h> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
