I tested on AMD hardware, I thought I had turned on the Intel KVM module as well, but it turns out I hadn't. Will fix in v3.--- diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c @@ -4995,7 +4995,7 @@ static int handle_rmode_exception(struct kvm_vcpu *vcpu, if (emulate_instruction(vcpu, 0) == EMULATE_DONE) { if (vcpu->arch.halt_request) { vcpu->arch.halt_request = 0; - return kvm_emulate_halt(vcpu); + return kvm_emulate_halt_noskip(vcpu);noskip is used without being declared ... it shouldn't compile.
*_noskip makes the usual case harder to undertand: we just want to halt the vcpu, so name it more directly ... like kvm_vcpu_halt()?
I like that better. Will make the change in v3. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
