On Mon, 2 Mar 2015 22:05:18 +0100 Pavel Machek <[email protected]> wrote: > On Tue 2015-02-24 15:33:51, NeilBrown wrote: > > We will need this calculation in other places, so > > create functions to map between register value and uA value. > > > > Signed-off-by: NeilBrown <[email protected]> > > Acked-by: Pavel Machek <[email protected]>
Thanks.
>
> > +static int regval2ua(int regval, bool cgain)
> > +{
> > + if (cgain)
> > + return (regval * 16618 - 8500 * 1000) / 5;
> > + else
> > + return (regval * 16618 - 8500 * 1000) / 10;
> > +}
>
> int res = (regval * 16618 - 8500 * 1000);
> if (cgain)
> return res / 5;
> return res / 10;
>
> ?
> Pavel
Maybe ... not sure it is really more readable. I think I'll leave it as is.
Thanks,
NeilBrown
pgpLQ8unb2kOJ.pgp
Description: OpenPGP digital signature
