On Wed, Mar 4, 2015 at 6:39 AM, Brian Gerst <brge...@gmail.com> wrote: > > On Wed, Mar 4, 2015 at 12:14 AM, Ingo Molnar <mi...@kernel.org> wrote: > > > > * Brian Gerst <brge...@gmail.com> wrote: > > > >> Use the generic compat syscall audit code instead of an x86 specific > >> implementation. > >> > >> Signed-off-by: Brian Gerst <brge...@gmail.com> > >> --- > >> arch/x86/Kconfig | 5 +-- > >> arch/x86/ia32/Makefile | 3 -- > >> arch/x86/ia32/audit.c | 43 --------------------- > >> arch/x86/include/asm/unistd32.h | 2 + > >> arch/x86/kernel/Makefile | 2 - > >> arch/x86/kernel/audit_64.c | 82 > >> ----------------------------------------- > >> 6 files changed, 3 insertions(+), 134 deletions(-) > >> delete mode 100644 arch/x86/ia32/audit.c > >> create mode 100644 arch/x86/include/asm/unistd32.h > >> delete mode 100644 arch/x86/kernel/audit_64.c > > > > Nice! > > > > Because there are many types of conversions it would be nice if the > > changelog included a declaration of some sorts about what this means > > precisely: 'the two implementations were 100% identical', or 'the x86 > > one was buggy and we now switch to the correct generic one', or 'the > > only difference between the two is X, Y and Z, which is not a > > problem'? > > > > Thanks, > > > > Ingo > > The generic compat version was added along with the arm64 support. It > is functionally equivalent to the x86-specific implementation. The > main difference is using audit_is_compat() instead of a hardcoded > check for AUDIT_ARCH_I386. > > I just noticed a bug in lib/compat_audit.c though. It is missing > __NR_execveat.
Sorry I missed that. I'll send a patch (and cc: stable for 3.19). > -- > Brian Gerst -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
