On Wed, 4 Mar 2015 23:16:41 +0900 Sergey Senozhatsky
<sergey.senozhat...@gmail.com> wrote:
> +static ssize_t zram_add_show(struct class *class,
> + struct class_attribute *attr,
> + char *buf)
> +{
> + int ret;
> +
> + mutex_lock(&zram_index_mutex);
> + /* read operation on zram_add is - pick up device_id
> + * automatically, add corresponding device and return
> + * that device_id back to user */
> + ret = zram_add(-1);
> + mutex_unlock(&zram_index_mutex);
> +
> + if (ret < 0)
> + return ret;
> + return scnprintf(buf, PAGE_SIZE, "%d\n", ret);
> +}
Please don't invent new commenting styles. Because doing so inevitably
creates a mixed-up mess, which is what we now have.
---
a/drivers/block/zram/zram_drv.c~zram-introduce-automatic-device_id-generation-fix
+++ a/drivers/block/zram/zram_drv.c
@@ -1281,9 +1281,10 @@ static ssize_t zram_add_show(struct clas
int ret;
mutex_lock(&zram_index_mutex);
- /* read operation on zram_add is - pick up device_id
- * automatically, add corresponding device and return
- * that device_id back to user */
+ /*
+ * read operation on zram_add is - pick up device_id automatically, add
+ * corresponding device and return that device_id back to user
+ */
ret = zram_add(-1);
mutex_unlock(&zram_index_mutex);
_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
