* Robert ABEL <ra...@cit-ec.uni-bielefeld.de> [150227 08:00]: > These are the changes I proposed in these patch series: [1], [2], [3], [4] > rebased to 3.19 as well as new changes for little bugs I noticed while > preparing this patch series as well as changes introduced via comments. > > 1. DEBUG was undefined in source code --> remove offending lines > 2. add capability to have busses as children of the GPMC and multiple > devices on a bus. See [2] for an example DTS syntax. > 3. debug output was unaligned --> align it > 4. output for copy-pasting to DTS had erroneous timing outputs and > made it hard to copy-paste --> correct timing values, add comments > as DTS comments. > 5. WAITMONITORINGTIME is expressed as GPMC_CLK cycles for all accesses. > GPMCFCLKDIVIDER is used as a divider, so it must always be programmed. > 6. GPMCFCLKDIVIDER is calculated according to WAITMONITORINGTIME for > asynchronous accesses inside the driver --> asynchronous accesses now > completely decoupled from gpmc,sync-clk-ps. > 7. WAITMONITORINGTIME was being programmed/shown in GPMC_FCLK cycles instead > of GPMC_CLK cycles --> add clock domain information where necessary. > 8. Calculated values for WAITMONITORINGTIME and CLKACTIVATIONTIME that were > outside the defined range would not raise an error. > DEVICESIZE, ATTACHEDDEVICEPAGELENGTH, WAITMONITORINGTIME and > CLKACTIVATIONTIME would not be marked as incorrect on DTS output. > --> Fix all of these.
Thanks for fixing all these issues: Acked-by: Tony Lindgren <t...@atomide.com> > [1]: https://lkml.org/lkml/2015/2/12/495 > [2]: https://lkml.org/lkml/2015/2/16/337 > [3]: https://lkml.org/lkml/2015/2/24/609 > [4]: https://lkml.org/lkml/2015/2/26/387 > > Robert ABEL (9): > ARM OMAP2+ GPMC: don't undef DEBUG > ARM OMAP2+ GPMC: add bus children > ARM OMAP2+ GPMC: fix debug output alignment > ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS > ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER > ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME > ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug > ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters > > arch/arm/mach-omap2/gpmc-nand.c | 17 +- > arch/arm/mach-omap2/gpmc-onenand.c | 4 +- > arch/arm/mach-omap2/usb-tusb6010.c | 4 +- > drivers/memory/Makefile | 2 + > drivers/memory/omap-gpmc.c | 313 > +++++++++++++++++++++++++++++-------- > include/linux/omap-gpmc.h | 2 +- > 6 files changed, 265 insertions(+), 77 deletions(-) > > -- > 2.3.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
