On 03/04/2015 03:41 AM, Michael Ellerman wrote: > There's no need to open-code the build rules, use the implicit ones. > > This has the nice side effect of enabling cross compilation. > > Signed-off-by: Michael Ellerman <m...@ellerman.id.au> > --- > tools/testing/selftests/timers/Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/timers/Makefile > b/tools/testing/selftests/timers/Makefile > index 149cee3b7b8a..87340405e4b3 100644 > --- a/tools/testing/selftests/timers/Makefile > +++ b/tools/testing/selftests/timers/Makefile > @@ -1,9 +1,9 @@ > -all: > - gcc posix_timers.c -o posix_timers -lrt > - > TEST_PROGS := posix_timers > +LDLIBS += -lrt > + > +all: $(TEST_PROGS)
I can't take this patch. This breaks make kselftest run. With this change timers test fails to build make[2]: Nothing to be done for 'all'. make[2]: *** No rule to make target 'posix_timers', needed by 'all'. Stop. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shua...@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
