Hi!
> > +config TOUCHSCREEN_COLLIE
> > + tristate "Collie touchscreen (for Sharp SL-5500)"
> > + depends on MCP_UCB1200 && INPUT
>
> I don't think you need && INPUT here.
Fixed.
> > obj-$(CONFIG_TOUCHSCREEN_BITSY) += h3600_ts_input.o
> > obj-$(CONFIG_TOUCHSCREEN_CORGI) += corgi_ts.o
> > +obj-$(CONFIG_TOUCHSCREEN_COLLIE)+= collie_ts.o
>
> A tab would be nice.
Actually, that would break lining-up. But you have to look at
resulting file, not a patch.
> > +static int ucb1x00_ts_open(struct input_dev *idev)
> > +{
> > + struct ucb1x00_ts *ts = (struct ucb1x00_ts *)idev;
> > + int ret = 0;
> > +
> > + if (down_interruptible(&ts->sem))
> > + return -EINTR;
> > +
> > + if (ts->use_count++ != 0)
> > + goto out;
> > +
>
> Please kill both ts->sem and ts->use_count - input core already serializes
> input_open and input_close.
Done. Still have to do the kthread conversion.
> > +
> > +MODULE_PARM(adcsync, "i");
> > +MODULE_PARM_DESC(adcsync, "Enable use of ADCSYNC signal");
>
> Die, MODULE_PARM, die!
Dead :-).
Pavel
--
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
