"Michael S. Tsirkin" <[email protected]> writes: > On Thu, Mar 12, 2015 at 11:54:10AM +1030, Rusty Russell wrote: >> "Michael S. Tsirkin" <[email protected]> writes: >> > On device hot-unplug, 9p/virtio currently will kfree channel while >> > it might still be in use. >> > >> > Of course, it might stay used forever, so it's an extremely ugly hack, >> > but it seems better than use-after-free that we have now. >> > >> > Signed-off-by: Michael S. Tsirkin <[email protected]> >> >> I'll apply it, but it looks like a bandaid. > > > Absolutely.
Applied this, too: Signed-off-by: Rusty Russell <[email protected]> diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c index 73fab71397ce..781315d97ed5 100644 --- a/net/9p/trans_virtio.c +++ b/net/9p/trans_virtio.c @@ -659,7 +659,6 @@ static void p9_virtio_remove(struct virtio_device *vdev) { struct virtio_chan *chan = vdev->priv; unsigned long warning_time; - bool inuse; mutex_lock(&virtio_9p_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
