On 20 March 2015 at 11:14, Javi Merino <[email protected]> wrote: > We have grown a number of different implementations of > DIV_ROUND_CLOSEST_ULL throughout the kernel. Move the i915 one to > kernel.h so that it can be reused. > > Cc: Daniel Vetter <[email protected]> > Cc: Jani Nikula <[email protected]> > Cc: David Airlie <[email protected]> > Cc: Darrick J. Wong <[email protected]> > Cc: Guenter Roeck <[email protected]> > Cc: Andrew Morton <[email protected]> > Signed-off-by: Javi Merino <[email protected]> > --- > drivers/gpu/drm/i915/intel_drv.h | 4 +--- > include/linux/kernel.h | 11 +++++++++++ > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_drv.h > b/drivers/gpu/drm/i915/intel_drv.h > index eef79ccd0b7c..346e28fdd7dd 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -28,6 +28,7 @@ > #include <linux/async.h> > #include <linux/i2c.h> > #include <linux/hdmi.h> > +#include <linux/kernel.h> Hi Javi,
Small suggestion - can we include the header only where needed ? i915/intel_panel.c seems to be the only user of DIV_ROUND_CLOSEST which will need an update. Somewhat trivial pick but it will prevent ~40 unnecessary dives in kernel.h. Cheers, Emil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
