>> +struct pci_host_bridge *pci_create_host_bridge(
>> + struct device *parent, u32 db, struct list_head *resources)
>> +{
>> + int error;
>> + int bus = PCI_BUSNUM(db);
>> + int domain = PCI_DOMAIN(db);
>> + struct pci_host_bridge *host;
>> + struct resource_entry *window, *n;
>> +
>> + host = kzalloc(sizeof(*host), GFP_KERNEL);
>> + if (!host)
>> + return NULL;
>> +
>> + host->busnum = bus;
>> + host->domain = domain;
>> + /* If support CONFIG_PCI_DOMAINS_GENERIC, use
>> + * pci_host_assign_domain_nr() to assign domain
>> + * number instead PCI_DOMAIN(db).
>> + */
>> + pci_host_assign_domain_nr(host);
>
> At this point, host->dev.parent has not been assigned. However, when calling
> pci_host_assign_domain_nr(host), it calls
> pci_assign_domain_nr(host->dev.parent), which uses parent->of_node directly
> w/o checking if parent is NULL. This ended up causing NULL pointer exception
> when I do the test.
>
> I think we need to moveo host->dev.parent = parent before calling
> pci_host_assign_domain_nr(host).
Good catch! Hi Suravee, thanks for your test, I would assign host->dev.parent
before pci_host_assign_domain_nr().
Thanks!
Yijing.
>
> .
>
--
Thanks!
Yijing
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
