Hi, > > > > You are doing leXXX everywhere, that's VERSION_1 dependency. > > > > virtio_cread will do byteswaps differently without VERSION_1. > > > > Just don't go there.
> So to clarify, you dislike using __virtio32 in virtio input header? Well, as I understand things __virtio32 implies byteorder depends on whenever we are using VERSION_1 or not. And non-transitional drivers should not need it as everything is by definition little endian. So, yes, your suggestion to just require VERSION_1 in the driver implies in my eyes that there should be no reason to use __virtio32 instead of __le32. Or do I miss something here? cheers, Gerd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
