må den 25.07.2005 Klokka 17:56 (+0200) skreiv Rene Scharfe: > What's your opinion of the following patch, which explicitly states the > intent of nfs_block_bits()? It still needs patch 1 and 2.
I really don't like the choice of name. If you feel you must change the name, then make it something like nfs_blocksize_align(). That describes its function, instead of the implementation details. Cheers, Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
