Hi Maxime, On Thu, Mar 19, 2015 at 2:18 AM, maxime.ripard <[email protected]> wrote: > Hi Kevin, > > On Thu, Mar 19, 2015 at 12:05:06PM +0800, [email protected] wrote: >> >> One question I couldn't find any answer to is that does the SMP bit is >> >> set in secondary_startup? >> >> >> >> I couldn't find where it was set, but it still looks like the right >> >> thing to do, so I would expect the code to do that. >> > >> > I don't see it either. The sun8i code is just the sun6i code with the >> > power clamps removed. And sun6i secondary_startup was removed some time >> > ago in commit 1146b600044d ("ARM: sunxi: fix build for THUMB2_KERNEL"). >> > >> > ChenYu >> >> The SMP bit should be set in the function of "__v7_ca7mp_setup", which is >> located >> in the file: >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/mm/proc-v7.S?id=refs/tags/v4.0-rc4 >> I'm not sure if this is your discussion. > > It is, but I wasn't seeing it called anywhere in the secondary_startup > code path. > > I was expecting a direct call, but it looks like it's a dynamic call, > with a function-pointer like call, that is indeed run both in the > kernel entry point and the secondary_startup. > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/kernel/head.S?id=refs/tags/v4.0-rc4#n389
Are we waiting for Marc's input on this? ChenYu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
